feat: Survey UI updates #17658
Merged
feat: Survey UI updates #17658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
liyiy
reviewed
Sep 28, 2023
| @@ -2097,15 +2097,16 @@ export enum SurveyType { | |||
| export interface SurveyAppearance { | |||
| backgroundColor?: string | |||
| submitButtonColor?: string | |||
| textColor?: string | |||
There was a problem hiding this comment.
I think the other PR in the site app still supports textColor and descriptionTextColor, we should remove it there too then
|
There's some valid type errors in the code quality check, with |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ratingButtonActiveColor(changes selected number & emoji rating background/fill color - only available on rating surveys)borderColorplaceholder(only available on open surveys)position(changes where the survey appears on the user's site - left, center, right)